No concurrent array buffer sweeping for some tests #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Feb 11, 2020
victorgomes
approved these changes
Feb 11, 2020
camillobruni
pushed a commit
to camillobruni/node
that referenced
this pull request
Oct 28, 2020
This includes this node-side change: v8#109 Tests are disabled until --no-concurrent-array-buffer-sweeping flag is supported by Node's V8 version. As soon as this is supported tests can be run with this flag. Bug: v8:10064 Change-Id: I1eaf72a6dda76d7be60c9eee1877c98451013e35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/node-ci/+/2050771 Reviewed-by: Victor Gomes <[email protected]> Commit-Queue: Victor Gomes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --no-concurrent-array-buffer-sweeping to two tests that would fail otherwise with concurrent array buffer sweeping enabled.